To be honest duty_cycle=1 is an invalid value that we never tested. It kinda make no sense. It means that no carrier present. Do you have real life examples for this change?

I got this report from a friend, they had an IR file with all raws at duty cycle 1. I am not sure if it was captured or generated, but from what they were saying, it seemed to work correctly and do what it was intended to do on older firmware. With furi checks now, it would crash.

I got this report from a friend, they had an IR file with all raws at duty cycle 1. I am not sure if it was captured or generated, but from what they were saying, it seemed to work correctly and do what it was intended to do on older firmware. With furi checks now, it would crash.

That was clearly generated file. What happens with duty cycle 1.0: there will be no carrier frequency. We really'd like to know what system actually uses that kind of signal.

He told me it was set to 1 on purpose and used to test accurate IR measuring devices

@Willy-JL this will work, but not because it was designed to do so.

I highly don't recommend to use it for modulation debugging. Also after some experiments I found that some timings are slightly off.

I'll merge this PR, but more research required.